Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16884
to look at the new patch set (#2).
Change subject: IMPALA-10374: Limit iteration at
BufferedTupleStream::DebugString
......................................................................
IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString
BufferedTupleStream::DebugString() iterate std::list<Page> that can
potentially grow very large. As consequent, the returned string can grow
large as well and cause a problem as previously happen in IMPALA-9851.
With this patch, BufferedTupleStream::DebugString() only include maximum
of 100 first pages of page list.
Testing:
- Add new be test SimpleTupleStreamTest.ShortDebugString in
buffered-tuple-stream-test.cc
- Pass core tests
Change-Id: I6626c8d54f35f303c01f85be1dd9aa54c8ad9a2d
---
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/buffered-tuple-stream.cc
M be/src/runtime/buffered-tuple-stream.h
3 files changed, 73 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/16884/2
--
To view, visit http://gerrit.cloudera.org:8080/16884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6626c8d54f35f303c01f85be1dd9aa54c8ad9a2d
Gerrit-Change-Number: 16884
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
