Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16905 )
Change subject: IMPALA-10406: Query with analytic functions doesn't need to materialize the predicates bounded to kudu ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16905/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/16905/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1130 PS2, Line 1130: // The predicates that can be bounded to KuduScanNode don't need to materialize I think this is incorrect, only some conjuncts get pushed into Kudu (see extractKuduConjuncts()). For conjuncts that don't get pushed into Kudu, we still need to materialize the slots so we can evaluate them in the Impala KuduScanNode in the backend. Am I missing something? -- To view, visit http://gerrit.cloudera.org:8080/16905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba8371eff6ae1bcffd51b44843175c52f2127e46 Gerrit-Change-Number: 16905 Gerrit-PatchSet: 2 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 26 Dec 2020 19:49:31 +0000 Gerrit-HasComments: Yes
