Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16906 )
Change subject: IMPALA-2536: Make ColumnType constructor explicit ...................................................................... IMPALA-2536: Make ColumnType constructor explicit This avoids accidental implicit type conversions from the PrimitiveType enum, or worse, integer values via the enum. Testing: Ran core tests. Change-Id: I2fe1d5da051c10904605328607bea78565356ef3 Reviewed-on: http://gerrit.cloudera.org:8080/16906 Reviewed-by: Wenzhe Zhou <[email protected]> Reviewed-by: Quanlong Huang <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/benchmarks/hash-benchmark.cc M be/src/codegen/llvm-codegen-test.cc M be/src/exec/grouping-aggregator.cc M be/src/exec/hash-table-test.cc M be/src/exec/hash-table.cc M be/src/exec/hdfs-scanner.cc M be/src/exprs/case-expr.cc M be/src/exprs/compound-predicates.cc M be/src/exprs/expr-test.cc M be/src/exprs/is-not-empty-predicate.cc M be/src/exprs/null-literal.h M be/src/exprs/valid-tuple-id.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/data-stream-test.cc M be/src/runtime/date-test.cc M be/src/runtime/krpc-data-stream-mgr.cc M be/src/runtime/raw-value-test.cc M be/src/runtime/row-batch-serialize-test.cc M be/src/runtime/timestamp-test.cc M be/src/runtime/types.h M be/src/service/hs2-util.cc M be/src/testutil/desc-tbl-builder.h M be/src/util/avro-util.cc M be/src/util/symbols-util-test.cc 24 files changed, 244 insertions(+), 191 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, but someone else must approve Quanlong Huang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2fe1d5da051c10904605328607bea78565356ef3 Gerrit-Change-Number: 16906 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
