Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 )
Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/16911/4/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/16911/4/be/src/runtime/query-driver.cc@296 PS4, Line 296: status It's better to set runtime error for status before calling HandleRetryFailure(). http://gerrit.cloudera.org:8080/#/c/16911/4/be/src/runtime/query-driver.cc@357 PS4, Line 357: status != nullptr status should not be nullptr, otherwise line 364 will crash. Add DCHECK for status instead. http://gerrit.cloudera.org:8080/#/c/16911/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16911/4/be/src/service/impala-server.cc@2244 PS4, Line 2244: cancel nit: canceling and closing. -- To view, visit http://gerrit.cloudera.org:8080/16911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d Gerrit-Change-Number: 16911 Gerrit-PatchSet: 4 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Thu, 31 Dec 2020 20:05:41 +0000 Gerrit-HasComments: Yes
