Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 )
Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, sub_string and reverse functions ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/16908/2/tests/query_test/test_utf8_strings.py File tests/query_test/test_utf8_strings.py: http://gerrit.cloudera.org:8080/#/c/16908/2/tests/query_test/test_utf8_strings.py@18 PS2, Line 18: from tests.common.impala_test_suite import ImpalaTestSuite > flake8: F401 'pytest' imported but unused Done http://gerrit.cloudera.org:8080/#/c/16908/2/tests/query_test/test_utf8_strings.py@24 PS2, Line 24: @classmethod > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/16908/2/tests/query_test/test_utf8_strings.py@34 PS2, Line 34: n > flake8: E502 the backslash is redundant between brackets Done http://gerrit.cloudera.org:8080/#/c/16908/2/tests/query_test/test_utf8_strings.py@44 PS2, Line 44: > flake8: W391 blank line at end of file Done -- To view, visit http://gerrit.cloudera.org:8080/16908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0aaf3544e89f8a3d531ad6afe056b3658b525b7c Gerrit-Change-Number: 16908 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 04 Jan 2021 07:15:23 +0000 Gerrit-HasComments: Yes
