Aman Sinha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16912 )

Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16912/6/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test
File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test:

http://gerrit.cloudera.org:8080/#/c/16912/6/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2520
PS6, Line 2520: AND t.test_zip = 1 or (t.test_name='xyz' and t.zip=1);
My example query mistakenly omitted the parenthesis after the AND 
predicate..that's why you are getting a nested loop join  with all the OR 
predicates.  You may want to change this line to:
     AND (t.test_zip = 1 or (t.test_name='xyz' and t.zip=1));
This will ensure that you have a Hash Join with the equijoin predicate and the 
rest of the predicates can be pushed to the view.



--
To view, visit http://gerrit.cloudera.org:8080/16912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88
Gerrit-Change-Number: 16912
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Xiaoqing Gao <[email protected]>
Gerrit-Comment-Date: Tue, 05 Jan 2021 00:47:18 +0000
Gerrit-HasComments: Yes

Reply via email to