Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16890 )
Change subject: IMPALA-9975 (part 1): Various refactors for admission control daemon ...................................................................... IMPALA-9975 (part 1): Various refactors for admission control daemon This patch contains a variety of small refactors needed to enable the new admission control daemon, to separate them out from the main patch for ease of reviewing. The following changes are made: - A new class is introduced, DaemonEnv, which contains singleton objects common to all Impala daemons, currently just a MetricGroup and Webservers. The purpose is to reduce code duplication when the new admissiond daemon is added. This is analogous to how ExecEnv is used for impalad-specific singletons already. This patch modifies the catalogd and statestored to use DaemonEnv. impalads could also use DaemonEnv, but its tricky due to dependencies in the order of creation and initialization for objects such as the ReservationTracker and BufferPool relative to the MetricGroup and Webserver, so this is left for followup work. - Direct use of ExecEnv in ImpalaServicePool ahd AdmissionController is removed, as the admissiond will also need to use these classes and it will not have an ExecEnv. Testing: - Passed a run of existing core tests. Change-Id: I2e097e20458354f78bfc3477cac6fb3a2835f094 Reviewed-on: http://gerrit.cloudera.org:8080/16890 Reviewed-by: Thomas Tauber-Marshall <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/catalog/catalogd-main.cc M be/src/common/CMakeLists.txt A be/src/common/daemon-env.cc A be/src/common/daemon-env.h M be/src/rpc/impala-service-pool.cc M be/src/rpc/impala-service-pool.h M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/rpc-mgr-test.cc M be/src/rpc/rpc-mgr-test.h M be/src/rpc/rpc-mgr.cc M be/src/rpc/rpc-mgr.h M be/src/runtime/data-stream-test.cc M be/src/runtime/exec-env.cc M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-controller-test.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/service/control-service.cc M be/src/service/data-stream-service.cc M be/src/statestore/statestored-main.cc 20 files changed, 215 insertions(+), 112 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e097e20458354f78bfc3477cac6fb3a2835f094 Gerrit-Change-Number: 16890 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
