Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16910 )
Change subject: [WIP] IMPALA-10410: Query hints for turn on/off UTF-8 behavior ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16910/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/16910/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2815 PS5, Line 2815: public void setIsUtf8Mode(boolean isUtf8Mode) throws AnalysisException{ > I mentioned this to you out-of-band but thought I should mention that I thi Yeah, I found some issues when adding more complex tests. I plan to make two refactors: 1) Change the isUtf8 marker from boolean to Boolean object. So it can have null as the initial state, which helps us detect whether the marker is reset. 2) In FE, move the isUtf8 marker from ScalarType to Expr. There are lots of Type instances shared in the metadata. We need explicitly cloning the Type instances in many places, which is error prone. Actually, CastExpr and FunctionCallExpr are the only places where the UTF8 semantic take place. Save the isUtf8 marker in them makes more sense. Still need to examine the substition codes to see whether we'll lose these markers. -- To view, visit http://gerrit.cloudera.org:8080/16910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fa20b62b5cb06169048b0785b70e85a9f21bf07 Gerrit-Change-Number: 16910 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 13 Jan 2021 09:17:15 +0000 Gerrit-HasComments: Yes
