Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 )
Change subject: [WiP] SAML implementation in Impala ...................................................................... Patch Set 10: (30 comments) http://gerrit.cloudera.org:8080/#/c/16833/10/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/16833/10/be/src/rpc/authentication.cc@1160 PS10, Line 1160: callbacks.get_saml_redirect_fn = std::bind(GetSaml2Redirect, connection_ptr.get()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/be/src/transport/THttpServer.h File be/src/transport/THttpServer.h: http://gerrit.cloudera.org:8080/#/c/16833/10/be/src/transport/THttpServer.h@160 PS10, Line 160: // 2. validating an authNRespone from the SSO provider line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16833/10/be/src/transport/THttpServer.h@192 PS10, Line 192: // Used to collect all information about the http request. Can be passed to the Frontend. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/AuthTokenGenerator.java File fe/src/main/java/org/apache/impala/authentication/saml/AuthTokenGenerator.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/AuthTokenGenerator.java@20 PS10, Line 20: // copy of https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/auth/saml/AuthTokenGenerator.java line too long (135 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlAuthTokenGenerator.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlAuthTokenGenerator.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlAuthTokenGenerator.java@32 PS10, Line 32: // https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/auth/saml/HiveSamlAuthTokenGenerator.java line too long (135 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlAuthTokenGenerator.java@52 PS10, Line 52: private static final Logger LOG = LoggerFactory.getLogger(HiveSamlAuthTokenGenerator.class); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlGroupNameFilter.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlGroupNameFilter.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlGroupNameFilter.java@31 PS10, Line 31: // https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/auth/saml/HiveSamlGroupNameFilter.java line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfo.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfo.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfo.java@20 PS10, Line 20: // copy of https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/auth/saml/HiveSamlRelayStateInfo.java line too long (139 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStore.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStore.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStore.java@32 PS10, Line 32: // slightly modified copy of https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/auth/saml/HiveSamlRelayStateInfo.java line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStore.java@32 PS10, Line 32: // slightly modified copy of https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/auth/saml/HiveSamlRelayStateInfo.java line too long (158 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClient.java File fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClient.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClient.java@42 PS10, Line 42: // modified version of https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/auth/saml/HiveSaml2Client.java line too long (144 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClient.java@65 PS10, Line 65: //TODO handle the replayCache as described in http://www.pac4j.org/docs/clients/saml.html line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClient.java@146 PS10, Line 146: // This is done to keep original structure by Vihang + keep ImpalaSamlClient as the only line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClient.java@191 PS10, Line 191: // https://github.com/vihangk1/hive/blob/master_saml/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClient.java@192 PS10, Line 192: private String doSamlAuth(WrappedWebContext webContext) throws HttpSamlAuthenticationException { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/service/BackendConfig.java File fe/src/main/java/org/apache/impala/service/BackendConfig.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/service/BackendConfig.java@245 PS10, Line 245: public String getSaml2GroupAttibuteName() { return backendCfg_.saml2_group_attribute_name; } line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/16833/10/fe/src/main/java/org/apache/impala/service/JniFrontend.java@688 PS10, Line 688: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py File tests/custom_cluster/test_saml2_sso.py: http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@20 PS10, Line 20: import logging flake8: F401 'logging' imported but unused http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@28 PS10, Line 28: from tests.common.impala_service import ImpaladService flake8: F401 'tests.common.impala_service.ImpaladService' imported but unused http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@31 PS10, Line 31: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.run_impala_shell_cmd_no_expect' imported but unused http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@31 PS10, Line 31: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.ImpalaShell' imported but unused http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@34 PS10, Line 34: class NoRedirection(urllib2.HTTPErrorProcessor): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@41 PS10, Line 41: class TestClientSsl(CustomClusterTestSuite): flake8: E303 too many blank lines (3) http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@46 PS10, Line 46: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@46 PS10, Line 46: SP_URL = "https://localhost:8443/simplesaml/saml2/idp/SSOService.php"; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@82 PS10, Line 82: r flake8: F841 local variable 'relay_state' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@97 PS10, Line 97: d flake8: F841 local variable 'decoded_saml_req' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@103 PS10, Line 103: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@103 PS10, Line 103: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16833/10/tests/custom_cluster/test_saml2_sso.py@104 PS10, Line 104: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/16833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c026cba1b90e7ff6ec5ae49be78b0d1edd8dfa Gerrit-Change-Number: 16833 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 13 Jan 2021 22:54:53 +0000 Gerrit-HasComments: Yes
