Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16930 )
Change subject: IMPALA-10387: Add missing overloads of mask functions used in Ranger default masking policies ...................................................................... Patch Set 3: (2 comments) > I don't agree with some of the behaviors (e.g. date->0001-01-01 in > mask/last_4/first_4), but if Hive works this way, then we should follow it. Yeah, some behaviors are weird to me as well. Just following Hive in this patch. I think we should document them somewhere. http://gerrit.cloudera.org:8080/#/c/16930/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/16930/2/tests/authorization/test_ranger.py@1024 PS2, Line 1024: masking > typo Done http://gerrit.cloudera.org:8080/#/c/16930/2/tests/authorization/test_ranger.py@1030 PS2, Line 1030: masking > typo Done -- To view, visit http://gerrit.cloudera.org:8080/16930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf3e70fd7aa9f3b6d6b508b776696e61ec1fcc2e Gerrit-Change-Number: 16930 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 14 Jan 2021 02:38:17 +0000 Gerrit-HasComments: Yes
