Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 )
Change subject: IMPALA-9979: part 2: partitioned top-n ...................................................................... Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/16242/22/testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q44.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q44.test: http://gerrit.cloudera.org:8080/#/c/16242/22/testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q44.test@496 PS22, Line 496: | limit: 10 This limit is a bug, since the exchange limit doesn't factor in ties. Probably should modify top-n so that it doesn't implement the limit as a PlanNode.limit_, because that breaks the invariant around limits where the node can't return more than that number of rows. -- To view, visit http://gerrit.cloudera.org:8080/16242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic638af9495981d889a4cb7455a71e8be0eb1a8e5 Gerrit-Change-Number: 16242 Gerrit-PatchSet: 22 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 14 Jan 2021 04:08:33 +0000 Gerrit-HasComments: Yes
