Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16959 )
Change subject: IMPALA-10440: Import Theta functionality from DataSketches ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16959/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16959/2//COMMIT_MSG@15 PS2, Line 15: This affects files originated from theta/ directories also files were changed in hll/ kll/ dirs http://gerrit.cloudera.org:8080/#/c/16959/2//COMMIT_MSG@22 PS2, Line 22: https://github.com/apache/datasketches-cpp Could you include a link that point to the particular git commit of the repo that we use here? http://gerrit.cloudera.org:8080/#/c/16959/2/be/src/exprs/datasketches-test.cc File be/src/exprs/datasketches-test.cc: http://gerrit.cloudera.org:8080/#/c/16959/2/be/src/exprs/datasketches-test.cc@176 PS2, Line 176: nit: drop the extra empty line http://gerrit.cloudera.org:8080/#/c/16959/2/be/src/thirdparty/datasketches/README.md File be/src/thirdparty/datasketches/README.md: http://gerrit.cloudera.org:8080/#/c/16959/2/be/src/thirdparty/datasketches/README.md@1 PS2, Line 1: HLL CPC Theta nit: please use a comma between these names. Additionally, could you please arrange them in alphabetical order? -- To view, visit http://gerrit.cloudera.org:8080/16959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8485d6829f50b130c84ec8bef0a4b5895255ba6c Gerrit-Change-Number: 16959 Gerrit-PatchSet: 2 Gerrit-Owner: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Jan 2021 12:56:28 +0000 Gerrit-HasComments: Yes
