Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14399 )

Change subject: WIP: IMPALA-2138: part 4: implicit cast handling
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14399/2/fe/src/main/java/org/apache/impala/analysis/CastExpr.java
File fe/src/main/java/org/apache/impala/analysis/CastExpr.java:

http://gerrit.cloudera.org:8080/#/c/14399/2/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@91
PS2, Line 91:         //   TINYINT->STRING, because DECIMAL and DOUBLE have 
different semantics to TINYINT
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/14399/2/fe/src/main/java/org/apache/impala/analysis/RangePartition.java
File fe/src/main/java/org/apache/impala/analysis/RangePartition.java:

http://gerrit.cloudera.org:8080/#/c/14399/2/fe/src/main/java/org/apache/impala/analysis/RangePartition.java@199
PS2, Line 199:               + "(type: %s) is not type compatible with 
partitioning column '%s' (type: %s).",
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/14399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50b7d28d691d65ee721581216d227d52f04ecf5
Gerrit-Change-Number: 14399
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Mon, 25 Jan 2021 19:53:42 +0000
Gerrit-HasComments: Yes

Reply via email to