Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16979 )
Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax ...................................................................... Patch Set 2: (1 comment) Thanks for the comment, Gabor! http://gerrit.cloudera.org:8080/#/c/16979/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/16979/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@725 PS1, Line 725: Preconditions.checkState(getIcebergPartitionSpecs().isEmpty()); > Please add a test to cover the error case when Iceberg's "PARTITION BY SPEC This raises a syntax error. Added tests about it to iceberg-negative.test -- To view, visit http://gerrit.cloudera.org:8080/16979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I789876c161bc0987820955aa9ae01414e0dcb45d Gerrit-Change-Number: 16979 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 26 Jan 2021 16:08:29 +0000 Gerrit-HasComments: Yes
