Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16993 )
Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16993/1/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/16993/1/be/src/exec/hdfs-table-sink.cc@264 PS1, Line 264: += optional: maybe it would be clearer to do two separate Substitute based on output_partition->partition_name.empty()? "$0/data/" and "$0/data/$1/" would show it clearly how the paths will look. -- To view, visit http://gerrit.cloudera.org:8080/16993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5ecac78102ed35710dd70a18edc71f6e891e748 Gerrit-Change-Number: 16993 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 29 Jan 2021 16:17:52 +0000 Gerrit-HasComments: Yes
