Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests ...................................................................... Patch Set 1: (2 comments) Hi Gabor, found 2 nits, aside from those LGTM! http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py@42 PS1, Line 42: occured nit: occurred http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py@48 PS1, Line 48: "\n" nit: this could just go after the previous line, like error_msg += str(thread.fetch_results_error) + "\n" -- To view, visit http://gerrit.cloudera.org:8080/16985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100 Gerrit-Change-Number: 16985 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 01 Feb 2021 13:09:41 +0000 Gerrit-HasComments: Yes
