Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )
Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441 ...................................................................... Patch Set 2: (4 comments) > Patch Set 1: > > (4 comments) > > Hi Quanlong, found some nits, aside from those LGTM! Thanks for catching up this! http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py File bin/load-data.py: http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py@29 PS1, Line 29: import sqlpar > nit: this becomes unused with this change Done http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py@33 PS1, Line 33: import tracebac > nit: this becomes unused with this change Done http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py@30 PS1, Line 30: import socket > nit: this becomes unused with this change Done http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py@33 PS1, Line 33: from functools > nit: this becomes unused with this change Done -- To view, visit http://gerrit.cloudera.org:8080/17011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0 Gerrit-Change-Number: 17011 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 03 Feb 2021 02:02:16 +0000 Gerrit-HasComments: Yes
