Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17023 )
Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs ...................................................................... IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs When the Partition-by and Order-by expressions of an analytic are all constants, it should be evaluated in a single unpartitioned fragment (same as analytics that have no Partition-by/Order-by exprs). Currently, it's placed within the same fragment with the child node, which causes it to be computed locally and get incorrect results when the fragment is partitioned. Tests: - Added planner tests - Added e2e tests Change-Id: Ibc88a410dab984ff37e27dc635bee5f289003a2a Reviewed-on: http://gerrit.cloudera.org:8080/17023 Reviewed-by: Aman Sinha <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test 4 files changed, 171 insertions(+), 5 deletions(-) Approvals: Aman Sinha: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibc88a410dab984ff37e27dc635bee5f289003a2a Gerrit-Change-Number: 17023 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
