Andrew Sherman has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17028 )

Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

LGTM, a few cosmetic nits

http://gerrit.cloudera.org:8080/#/c/17028/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17028/1//COMMIT_MSG@12
PS1, Line 12: falkiness by increasing the timeout and adding more logging in 
case
nit: flakiness


http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:

http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py@60
PS1, Line 60:       "cluster-membership.backends.total")
Nit: tidier to use a variable for "cluster-membership.backends.total" rather 
than repeating the name



--
To view, visit http://gerrit.cloudera.org:8080/17028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514
Gerrit-Change-Number: 17028
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sat, 06 Feb 2021 01:24:34 +0000
Gerrit-HasComments: Yes

Reply via email to