Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16656 )
Change subject: IMPALA-10282: Implement ds_cpc_sketch() and ds_cpc_estimate() functions ...................................................................... Patch Set 4: Hey, This review has been open for a while now. Do you have any updates on my comment/question? I see you pushed another review to include Theta sketch for cardinality estimates. With that we'll have 3 different algorithms for DataSketches for the same purpose and it makes me wonder which one is better for which purpose. -- To view, visit http://gerrit.cloudera.org:8080/16656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731e66fbadc74bc339c973f4d9337db9b7dd715a Gerrit-Change-Number: 16656 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 09 Feb 2021 13:52:58 +0000 Gerrit-HasComments: No
