Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17039 )
Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/17039/1/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/17039/1/be/src/exec/orc-column-readers.cc@291 PS1, Line 291: inline uint64_t OrcComplexColumnReader::GetTargetColId( : const SlotDescriptor* slot_desc) const { : return slot_desc->type().IsCollectionType() ? : > This is no longer used. Done http://gerrit.cloudera.org:8080/#/c/17039/1/be/src/exec/orc-column-readers.cc@296 PS1, Line 296: } > This is no longer used too. Done http://gerrit.cloudera.org:8080/#/c/17039/1/be/src/exec/orc-column-readers.cc@311 PS1, Line 311: * Return the result in '*child' and its index inside the children. Returns false for > nit: inline? Done http://gerrit.cloudera.org:8080/#/c/17039/1/be/src/exec/orc-column-readers.cc@316 PS1, Line 316: DCHECK(parent.getKind() == orc::TypeKind::STRUCT || > Could you move the original comments of FindChild here? Added a bit more verbose comment. -- To view, visit http://gerrit.cloudera.org:8080/17039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f7d521f9397c5188fadc7996cee0bd1650d363e Gerrit-Change-Number: 17039 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 10 Feb 2021 15:23:42 +0000 Gerrit-HasComments: Yes
