Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17064 )
Change subject: IMPALA-9745: Propagate source type when doing constant propagation ...................................................................... IMPALA-9745: Propagate source type when doing constant propagation When doing constant propagation the source type was not being propagated to the target expression leading to an analysis failure. The behavior is most easily reproducible with STRING to TIMESTAMP conversion in the presence of other predicates. This patch fixes this by adding an implicit cast if needed for such cases. Testing: - Added planner test and ran other planner tests - Added end-to-end test Change-Id: Ic3853478945229440f733c256ea225639f9178ff Reviewed-on: http://gerrit.cloudera.org:8080/17064 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Aman Sinha <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java M testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test M testdata/workloads/functional-query/queries/QueryTest/range-constant-propagation.test 3 files changed, 38 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Aman Sinha: Verified -- To view, visit http://gerrit.cloudera.org:8080/17064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic3853478945229440f733c256ea225639f9178ff Gerrit-Change-Number: 17064 Gerrit-PatchSet: 5 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
