Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 )
Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile ...................................................................... Patch Set 3: (13 comments) Thank you for the feedback! http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py File bin/diagnostics/experimental/plan-graph.py: http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@29 PS2, Line 29: read > nit: 'reads' instead of 'read' Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@29 PS2, Line 29: outpu > nit: outputs Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@30 PS2, Line 30: representation > nit: spelling Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@36 PS2, Line 36: is availa > nit: 'is available' Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@154 PS2, Line 154: parse > nit: parses Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@221 PS2, Line 221: if > nit: if Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@267 PS2, Line 267: represent > nit: represents Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@286 PS2, Line 286: represent > nit: represents Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@430 PS2, Line 430: contribute > nit: contributes Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@431 PS2, Line 431: have fin > nit: finish or 'should have finished' Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@592 PS2, Line 592: section > nit: section Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@619 PS2, Line 619: outpu > nit: outputs Done http://gerrit.cloudera.org:8080/#/c/17077/2/bin/diagnostics/experimental/plan-graph.py@619 PS2, Line 619: read > nit: reads Done -- To view, visit http://gerrit.cloudera.org:8080/17077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62e3c2b061dd2b84589336fb9e68fa1eccf76f2 Gerrit-Change-Number: 17077 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 17 Feb 2021 23:10:20 +0000 Gerrit-HasComments: Yes
