Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17078 )

Change subject: IMPALA-10505: Avoid creating misleading audit logs
......................................................................


Patch Set 2:

Sorry that I forgot to mention how to reproduce the issue before this patch. It 
suffices to add the following test case in 
RangerAuditLogTest#testAuditLogSuccess() to reproduce the issue. Notice that 
the 3rd argument of the logged event is 0, indicating a failed privilege check 
for the underlying table functional.alltypes.

authzOk(events -> {
   assertEquals(1, events.size());
   assertEventEquals("@table", "select", "functional/alltypes", 0, 
events.get(0));
   assertEquals("select count(*) from functional.alltypes_view", 
events.get(0).getRequestData());
}, "select count(*) from functional.alltypes_view", onTable("functional", 
"alltypes_view", TPrivilegeLevel.SELECT));


--
To view, visit http://gerrit.cloudera.org:8080/17078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f40eb96d6ed863cd2cd88d717c354dc351a64c
Gerrit-Change-Number: 17078
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 18 Feb 2021 03:02:26 +0000
Gerrit-HasComments: No

Reply via email to