Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17075 )
Change subject: [WIP] IMPALA-10494: Making use of the min/max column stats to improve min/max filters ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/17075/2/be/src/exec/incr-stats-util.cc File be/src/exec/incr-stats-util.cc: http://gerrit.cloudera.org:8080/#/c/17075/2/be/src/exec/incr-stats-util.cc@123 PS2, Line 123: low_value.bool_val &= value.bool_val; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17075/2/be/src/exec/incr-stats-util.cc@150 PS2, Line 150: high_value.bool_val ^= value.bool_val; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17075/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/17075/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@293 PS2, Line 293: Preconditions.checkState(false, "Unsupported type encountered in setLowValue()"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17075/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@318 PS2, Line 318: Preconditions.checkState(false, "Unsupported type encountered in setLowValue()"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17075/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@350 PS2, Line 350: LOG.error("ColumnStats::update() with Hive ColumnStatisticsData!" + ", coltype=" + colType.toSql()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17075/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@354 PS2, Line 354: /// called. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17075/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@355 PS2, Line 355: /// line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/17075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08581b44419bb8da5940cbf98502132acd1c86df Gerrit-Change-Number: 17075 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 18 Feb 2021 14:15:15 +0000 Gerrit-HasComments: Yes
