Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17047 )
Change subject: IMPALA-10161: User LDAP Search bind support ...................................................................... Patch Set 3: Code-Review+1 (1 comment) I only found a small issue, can upgrade to +2 once it is resolved. http://gerrit.cloudera.org:8080/#/c/17047/3/be/src/util/ldap-search-bind.cc File be/src/util/ldap-search-bind.cc: http://gerrit.cloudera.org:8080/#/c/17047/3/be/src/util/ldap-search-bind.cc@112 PS3, Line 112: VLOG(2) << "LDAP bind successful" We write successful even if success is false. -- To view, visit http://gerrit.cloudera.org:8080/17047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I978744ad05d9ef408328d1e4dd2d18c329f4d3b7 Gerrit-Change-Number: 17047 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 18 Feb 2021 17:09:31 +0000 Gerrit-HasComments: Yes
