Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17086 )
Change subject: IMPALA-10519: Allow setting of num_reactors for KuduClient ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17086/2/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/17086/2/be/src/exec/kudu-util.cc@48 PS2, Line 48: 16 nit: maybe use the default 4 to be consistent with current setting, if we are not sure what a good default will be (as it may vary depends on the workload.) -- To view, visit http://gerrit.cloudera.org:8080/17086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2ccb9659b9223c9a5de2416b946e6313a3239ff Gerrit-Change-Number: 17086 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 19 Feb 2021 00:21:55 +0000 Gerrit-HasComments: Yes
