Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17071 )

Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: 
def_levels_.CacheRemaining() <= num_buffered_values_
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

It would be great to have Parquet file that triggers the original issue, but I 
am not sure how to create one.

http://gerrit.cloudera.org:8080/#/c/17071/2/be/src/exec/parquet/parquet-level-decoder.h
File be/src/exec/parquet/parquet-level-decoder.h:

http://gerrit.cloudera.org:8080/#/c/17071/2/be/src/exec/parquet/parquet-level-decoder.h@88
PS2, Line 88: CacheHasNext
LIKELY could be added



--
To view, visit http://gerrit.cloudera.org:8080/17071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic071473e7b315300fd5e163225d3e39735f09c4f
Gerrit-Change-Number: 17071
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 19 Feb 2021 17:44:36 +0000
Gerrit-HasComments: Yes

Reply via email to