Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 )
Change subject: IMPALA-10510: Change code to help with third party extensions ...................................................................... Patch Set 1: (1 comment) Patch itself it fairly simple. I just have some nits/questions below. Otherwise, this looks okay to me. http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1224 PS1, Line 1224: protected I think it would be useful to update the documentation of this method to describe why this is protected or what could be a potential usecase. Also, does it make sense to have loadSchema, loadAllColumnStats, loadConstraintsInfo and loadValidWriteIdList as protected as well then? -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Sat, 20 Feb 2021 00:42:30 +0000 Gerrit-HasComments: Yes
