[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 )
Change subject: IMPALA-9218: Add support for locally compiled Hive ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG@23 PS2, Line 23: export HIVE_HOME_OVERRIDE=~/hive/packaging/target/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin Not sure what the best choice here is - Should I split this line wiht a \ or is it more readable without? http://gerrit.cloudera.org:8080/#/c/17094/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17094/1/bin/bootstrap_toolchain.py@459 PS1, Line 459: hadoop = CdpComponent("hadoop") line length http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh@254 PS2, Line 254: export IMPALA_HIVE_STORAGE_API_VERSION=${HIVE_STORAGE_API_VERSION_OVERRIDE:-"2.3.0.$IMPALA_HIVE_VERSION"} I've tried to use good taste in the line length here. I know there is a recommended line length for C/C++/Java but I've seen examples in this file where others have traded readability for a bit of violation of line length. I have split one very long line below though. I can split the lines if that is preferred by the reviewers. Just ask, thanks. -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Sat, 20 Feb 2021 17:40:18 +0000 Gerrit-HasComments: Yes
