Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17104 )

Change subject: IMPALA-10535: Add interface to ImpalaServer for execution of 
externally compiled statements
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/17104/1/be/src/runtime/query-driver.cc
File be/src/runtime/query-driver.cc:

http://gerrit.cloudera.org:8080/#/c/17104/1/be/src/runtime/query-driver.cc@66
PS1, Line 66: Status QueryDriver::SetExternalPlan(const TQueryCtx& query_ctx, 
const TExecRequest& exec_request) {
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/17104/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/17104/1/be/src/service/impala-server.cc@316
PS1, Line 316:     "If set, dump TExecRequest structures to 
{dump_exec_request_path}/TExecRequest-{internal|external}.{query_id.hi}-{query_id.lo}");
line too long (133 > 90)


http://gerrit.cloudera.org:8080/#/c/17104/1/be/src/service/impala-server.cc@1101
PS1, Line 1101:   Status status = ExecuteInternal(*query_ctx, execRequest, 
session_state, &registered_query,
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/17104/1/be/src/service/impala-server.cc@1189
PS1, Line 1189:       // Takes the TQueryCtx and calls into the frontend to 
initialize the TExecRequest for
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/17104/1/be/src/service/impala-server.cc@1197
PS1, Line 1197:       
RETURN_IF_ERROR(query_handle->query_driver()->SetExternalPlan(query_ctx, 
*exec_request));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/17104/1/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

http://gerrit.cloudera.org:8080/#/c/17104/1/common/thrift/ImpalaService.thrift@831
PS1, Line 831:   TCLIService.TExecuteStatementResp 
ExecutePlannedStatement(1:TExecutePlannedStatementReq req);
line too long (95 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/17104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace716dd67290f08441857dc02d2428b0e335eaa
Gerrit-Change-Number: 17104
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sun, 21 Feb 2021 21:38:59 +0000
Gerrit-HasComments: Yes

Reply via email to