Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 )
Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc@171 PS1, Line 171: if( formatting (needs a space after 'if') http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc@1954 PS1, Line 1954: / The formatting here was correct before. If you're not already aware, there's a tool called clang-format-diff that you can use to do the formatting automatically, see: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Feb 2021 18:19:57 +0000 Gerrit-HasComments: Yes
