Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 )
Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables ...................................................................... Patch Set 2: Code-Review+2 (1 comment) This can go in from my side. http://gerrit.cloudera.org:8080/#/c/17081/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17081/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3194 PS2, Line 3194: LOG.error(String.format( : "Exception caught during increasing write id for table %s: %s", : tbl.getFullName(), ex)); : if (txnId != -1) { : try { : MetastoreShim.abortTransaction(msClient, txnId); : } catch (TransactionException abortEx) { : LOG.error(String.format( : "Could not abort transaction: %d. This transaction was opened to " + : "increase the write id of table %s during ADD PARTITION. Exception: %s", : txnId, tbl.getFullName(), abortEx)); : } : } nice to habve: there could be a function for this, e.g. cleanupFailedTransaction(long txnId, String operation, Exception ex) -- To view, visit http://gerrit.cloudera.org:8080/17081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad247008b7c206db00516326c1447bd00a9b34bd Gerrit-Change-Number: 17081 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Feb 2021 19:51:25 +0000 Gerrit-HasComments: Yes
