Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17078 )
Change subject: IMPALA-10505: Avoid creating misleading audit logs ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Thanks for the changes! http://gerrit.cloudera.org:8080/#/c/17078/5/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/17078/5/tests/authorization/test_ranger.py@1087 PS5, Line 1087: .format(test_db, test_view, grantee_user), user=ADMIN) > Thanks Csaba! hmm, maybe there are some rules in python I didn't know about. Probably the extra indentation would be only accepted if .format( was moved to the last line and the line break was between the parentheses. Never mind, it is good as it is. -- To view, visit http://gerrit.cloudera.org:8080/17078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02f40eb96d6ed863cd2cd88d717c354dc351a64c Gerrit-Change-Number: 17078 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 25 Feb 2021 10:14:51 +0000 Gerrit-HasComments: Yes
