Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17145 )

Change subject: IMPALA-10552: External Frontend CTAS support
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17145/1/be/src/exec/hdfs-table-sink.cc
File be/src/exec/hdfs-table-sink.cc:

http://gerrit.cloudera.org:8080/#/c/17145/1/be/src/exec/hdfs-table-sink.cc@131
PS1, Line 131:     staging_dir_ = Substitute("$0/_impala_insert_staging/$1", 
table_desc_->hdfs_base_dir(),
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/17145/1/be/src/exec/hdfs-table-sink.cc@232
PS1, Line 232: void HdfsTableSink::BuildHdfsFileNames(const 
HdfsPartitionDescriptor& partition_descriptor,
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/17145/1/be/src/exec/hdfs-table-sink.cc@506
PS1, Line 506:     bool external_part = HasExternalStagingDir() && j >= 
external_staging_partition_depth_;
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/17145/1/be/src/exec/hdfs-table-sink.cc@549
PS1, Line 549:   BuildHdfsFileNames(partition_descriptor, output_partition, 
external_partition_name_ss.str());
line too long (95 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/17145
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0ea4a832d8281c563427d0d7da1623bfce437b
Gerrit-Change-Number: 17145
Gerrit-PatchSet: 1
Gerrit-Owner: John Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: John Sherman <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Comment-Date: Mon, 01 Mar 2021 17:10:17 +0000
Gerrit-HasComments: Yes

Reply via email to