John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17125 )
Change subject: IMPALA-10550: Add External Frontend service port ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/17125/5/be/src/rpc/authentication.h File be/src/rpc/authentication.h: http://gerrit.cloudera.org:8080/#/c/17125/5/be/src/rpc/authentication.h@67 PS5, Line 67: Currently this is either null if external_fe_port <= 0 or : /// NoAuthProvider. > I think you put this above the wrong function? I totally did - usually I self review a little better. Thanks for catching. http://gerrit.cloudera.org:8080/#/c/17125/5/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/17125/5/bin/start-impala-cluster.py@235 PS5, Line 235: 'external_fe_port': DEFAULT_EXTERNAL_FE_PORT + instance_num, > What would you think about putting this behind a flag for now, eg. "start-i Done I went with the approach of excluding it in build_impalad_port_args since that seemed like a nice clean way of excluding it even if the map contains the port. -- To view, visit http://gerrit.cloudera.org:8080/17125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I991b5b05e12e37d8739e18ed1086bbb0228acc40 Gerrit-Change-Number: 17125 Gerrit-PatchSet: 5 Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 01 Mar 2021 22:26:04 +0000 Gerrit-HasComments: Yes
