Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 )
Change subject: IMPALA-10551: Add result sink support for external frontends ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17144/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17144/1//COMMIT_MSG@14 PS1, Line 14: - External frontends are responsible for managing the files after the : query is completed. I wonder how this would interact with the "retry_failed_queries" query option. That can reexecute a failed statement if no rows were fetched. Depending on how files are cleaned up, this could be a problem. We may want to throw an error if using this result sink when retry_failed_queries = True until we can test it. http://gerrit.cloudera.org:8080/#/c/17144/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/17144/1/be/src/runtime/coordinator.cc@798 PS1, Line 798: Coordinator::FinalizeResultSink() I might be missing something, but where is this called? http://gerrit.cloudera.org:8080/#/c/17144/1/be/src/runtime/coordinator.cc@907 PS1, Line 907: RETURN_IF_ERROR(UpdateExecState(coord_instance_->WaitForOpen(), : &coord_instance_->runtime_state()->fragment_instance_id(), FLAGS_hostname)); I'm thinking through the implication of calling this after WaitForBackends() for QUERY statements. I think it would delay the detection of certain types of errors, but I'm not sure if there are other problems. -- To view, visit http://gerrit.cloudera.org:8080/17144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I024bf41d77bb81f1ab0debdbd31ec3687c83f072 Gerrit-Change-Number: 17144 Gerrit-PatchSet: 1 Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 01 Mar 2021 23:01:42 +0000 Gerrit-HasComments: Yes
