Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17116 )
Change subject: IMPALA-10546: Add ImpalaServer interface to retrieve BackendConfig from impalad ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/17116/14/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/17116/14/be/src/service/impala-hs2-server.cc@1190 PS14, Line 1190: HS2_RETURN_IF_ERROR(return_val, THandleIdentifierToTUniqueId( > I think you may have misunderstood my previous comment here, sorry if I was This RPC uses common Client and Session logic on the external frontend to connect to Impalad. Originally it was not clear if we might need authentication for external frontend connections. The external port was added later but then rebased before this change to make it more clear how security would work and avoid having an interim security hole. I'd prefer to leave this as-is for now. http://gerrit.cloudera.org:8080/#/c/17116/14/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/17116/14/be/src/util/backend-gflag-util.cc@258 PS14, Line 258: string saml2_private_key_password; > As is, this patch will return things from GetBackendConfig that are both se The intention with external frontends is to share Impala frontend code and functionality. As such, we have not limited access to backend metadata which may be needed in unforeseen places, especially as more functionality is added. As it stands, this mechanism simply mirrors what the Impala FE is getting, excepted pulled rather than pushed. The log case as easier to make as restricting access there is not going to cause functional problems. -- To view, visit http://gerrit.cloudera.org:8080/17116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14a3cee29f1fc91f4431b7ea89053bb3fbfa5e69 Gerrit-Change-Number: 17116 Gerrit-PatchSet: 14 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 03 Mar 2021 02:57:29 +0000 Gerrit-HasComments: Yes
