Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17164 )
Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified ...................................................................... IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified ImpalaJdbcClient might silently choose the HiveDriver when the connection string is not specified. It's because the default connection string is 'jdbc:hive2://...'. This patch adds a check to ImpalaJdbcClient to make sure the driver being used is the one specified by the user. If not, it raises an error. I also modified bin/run-jdbc-client.sh to make it easier to use different drivers. Users are now able to specify the classpath of their custom driver via the environment variable IMPALA_JDBC_DRIVER_CLASSPATH. Testing: * tested manually Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f Reviewed-on: http://gerrit.cloudera.org:8080/17164 Reviewed-by: Thomas Tauber-Marshall <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M bin/run-jdbc-client.sh M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java 2 files changed, 15 insertions(+), 2 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f Gerrit-Change-Number: 17164 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
