liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 )
Change subject: IMPALA-10377: Improve the accuracy of resource estimation ...................................................................... Patch Set 21: (2 comments) I have rebased and committed code http://gerrit.cloudera.org:8080/#/c/16842/20/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/16842/20/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1052 PS20, Line 1052: ++numCols; > nit: Impala prefers to use "++numCols" Done http://gerrit.cloudera.org:8080/#/c/16842/20/fe/src/main/java/org/apache/impala/planner/PlannerContext.java File fe/src/main/java/org/apache/impala/planner/PlannerContext.java: http://gerrit.cloudera.org:8080/#/c/16842/20/fe/src/main/java/org/apache/impala/planner/PlannerContext.java@41 PS20, Line 41: be/src/exec/hash-table.h > It would be good to add a comment in hash-table.h above 'struct Bucket' say Done -- To view, visit http://gerrit.cloudera.org:8080/16842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic01db168ff2c6d6de33ee553a8175599f035d7a1 Gerrit-Change-Number: 16842 Gerrit-PatchSet: 21 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Wed, 10 Mar 2021 03:16:51 +0000 Gerrit-HasComments: Yes
