Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter ...................................................................... Patch Set 2: (5 comments) Hi Shajini, thank you for the update. Just a few nits, outside of those looks good to me. Impala commit messages usually explain the change and are complete sentences, left a few nits on the commit message. http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG@9 PS2, Line 9: discussed the newly added scale argument of ndv function I think this part of the commit message is not relevant to the content of the commit. Could you remove it please? http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG@10 PS2, Line 10: m nit: missing punctuation mark http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG@10 PS2, Line 10: a nit: capital A http://gerrit.cloudera.org:8080/#/c/17131/2/docs/topics/impala_ndv.xml File docs/topics/impala_ndv.xml: http://gerrit.cloudera.org:8080/#/c/17131/2/docs/topics/impala_ndv.xml@72 PS2, Line 72: nit: empty tab http://gerrit.cloudera.org:8080/#/c/17131/2/docs/topics/impala_ndv.xml@77 PS2, Line 77: nit: empty tab -- To view, visit http://gerrit.cloudera.org:8080/17131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77 Gerrit-Change-Number: 17131 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Mar 2021 09:57:05 +0000 Gerrit-HasComments: Yes
