Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 )
Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit ...................................................................... Patch Set 6: > Patch Set 6: > > > Patch Set 6: > > > > > Patch Set 6: > > > > > > > Patch Set 6: Verified-1 > > > > > > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6965/ > > > > > > Looks like it hit flaky > > > TestScratchLimit::test_with_unlimited_scratch_limit (IMPALA-10559). > > > > Yeah, that is one failure..but I also see for the dockerized tests bunch of > > other failures: > > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3935/ although > > it seems the failures are all related to lost connection. > > E ImpalaBeeswaxException: ImpalaBeeswaxException: > > E INNER EXCEPTION: <class > > 'thrift.transport.TTransport.TTransportException'> > > E MESSAGE: TSocket read 0 bytes > > TestScratchLimit::test_with_unlimited_scratch_limit crash one of the impalad > due to DCHECK violation in reservation-tracker.cc:436. It is a violation when > BufferedTupleStream is spilling and subsequently allocating new page for read. > > It is unrelated with this patch. But the combination of sort query + result > spooling in this test seems to reveal another bug in BufferedTupleStream. > At this point, I think we should disable result spooling for all test in > TestScratchLimit (per discussion in IMPALA-10559 jira) and investigate it > separately. What do you think? Yes, let's do that. I presume you will explicitly enable result_spooling only for the following test? def test_result_spooling_and_varying_scratch_limit(self, vector): -- To view, visit http://gerrit.cloudera.org:8080/17166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I541f46e6911694e14c0fc25be1a6982fd929d3a9 Gerrit-Change-Number: 17166 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 13 Mar 2021 17:30:27 +0000 Gerrit-HasComments: No
