Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17171 )
Change subject: IMPALA-10579: Fix usage of RemoteIterator in FileSystemUtil ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17171/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17171/4//COMMIT_MSG@15 PS4, Line 15: dead nit, I think using "infinite loop" is a more readable. http://gerrit.cloudera.org:8080/#/c/17171/4//COMMIT_MSG@18 PS4, Line 18: thrown nit, throw http://gerrit.cloudera.org:8080/#/c/17171/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/17171/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@847 PS4, Line 847: next = baseIterator_.next(); Does this mean that if the file which is present inside a directory and which is removed after the RemoteIterator was created, we will start seeing FileNotFoundException which can cause Table loading errors? -- To view, visit http://gerrit.cloudera.org:8080/17171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I859bd4f976c51a34eb6a03cefd2ddcdf11656cea Gerrit-Change-Number: 17171 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 15 Mar 2021 17:17:40 +0000 Gerrit-HasComments: Yes
