Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 )
Change subject: IMPALA-10551: Add result sink support for external frontends ...................................................................... Patch Set 7: Code-Review+2 > > (1 comment) > > > > Apart from the interaction with retry_failed_queries, this looks > > good to me. > > > > If you want to split off the retry_failed_queries piece into a > > separate change, I am ok with that. I think this change is ok if > > the external frontend guarantees not to pass in retry_failed_queries=true > > when using a result sink. > > I think it would be better to follow up. I've created > https://issues.apache.org/jira/browse/IMPALA-10586 to track that > work. Ok, then this looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/17144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I024bf41d77bb81f1ab0debdbd31ec3687c83f072 Gerrit-Change-Number: 17144 Gerrit-PatchSet: 7 Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 15 Mar 2021 21:39:17 +0000 Gerrit-HasComments: No
