Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17122 )
Change subject: IMPALA-10549: Register transactions from external frontend DML ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/17122/12/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/17122/12/fe/src/main/java/org/apache/impala/service/Frontend.java@2048 PS12, Line 2048: try (MetaStoreClient client = metaStoreClientPool_.getClient()) { Why is it valid that a we might already have a transaction id here when we're always going to set it below? -- To view, visit http://gerrit.cloudera.org:8080/17122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8863b8d9d281a5d164f10de9c5ee52cf3be63db Gerrit-Change-Number: 17122 Gerrit-PatchSet: 14 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 16 Mar 2021 17:00:09 +0000 Gerrit-HasComments: Yes
