Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17184 )
Change subject: IMPALA-10483(part-1): Refactor table mask resolving ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Changes LGTM. http://gerrit.cloudera.org:8080/#/c/17184/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17184/1//COMMIT_MSG@23 PS1, Line 23: This patch refactor the table mask resolving logic to not apply table > Yeah, I think it's a trade-off. Before this patch we apply table mask by de Right. I think the test coverage would be more crucial now (for security reasons) compared to before where it may have at worst recursed. http://gerrit.cloudera.org:8080/#/c/17184/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java File fe/src/main/java/org/apache/impala/analysis/StmtNode.java: http://gerrit.cloudera.org:8080/#/c/17184/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java@41 PS2, Line 41: public void setDoTableMasking(boolean doTableMasking) {} Ideally, this should be an abstract method too such that derived classes ensure masking is done wherever appropriate..but I can understand why you would want to keep the changes minimal for this patch. -- To view, visit http://gerrit.cloudera.org:8080/17184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia191928fb179b0b0632235c1fff4c18647e5802f Gerrit-Change-Number: 17184 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 16 Mar 2021 17:15:42 +0000 Gerrit-HasComments: Yes
