Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17168 )
Change subject: IMPALA-10564: Return error when inserting an invalid decimal value ...................................................................... Patch Set 3: > Patch Set 2: > > Thanks for adding the check for Kudu tables and the unit tests. When > thinking about this a bit more, one concern I have is if a user was doing an > INSERT-SELECT of a billion row (or relatively large) table, would just one > decimal value overflowing error out the whole operation or will the rest of > the inserts go through ? I suppose this depends on the ABORT_ON_ERROR setting > ? > > ETL operations normally expect invalid/dirty rows to be logged into a > separate location while continuing with the insertion of other rows. We > should make sure this new behavior does not regress that workflow. Any > thoughts on that ? Posted a few comments in the JIRA to capture the decision points. I am leaning towards introducing a query option which would allow the CTAS to error out on the first decimal error. Let me know what you think. -- To view, visit http://gerrit.cloudera.org:8080/17168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ce4ed194af81ef06401ffc1124e12f05b8da98 Gerrit-Change-Number: 17168 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 16 Mar 2021 19:00:43 +0000 Gerrit-HasComments: No
