Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17209 )
Change subject: IMPALA-10594: Handle failed coordinators in admissiond ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17209/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17209/2//COMMIT_MSG@13 PS2, Line 13: > its also possible that the coordinator probably never went down but due to There won't be any overadmission because the executors also monitor the statestore for coordinator failures and fail any fragments: https://github.com/apache/impala/blob/master/be/src/runtime/query-exec-mgr.cc#L225 So, if a coordinator is temporarily unreachable, when it comes back up it'll find that all of its fragments are cancelled and it will just fail all of its queries. The statestore is pretty conservative about when it concludes an impalad is down, so it should be very rare that it decides an impalad is down when its actually not. -- To view, visit http://gerrit.cloudera.org:8080/17209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883f323bb765680ef24b3c3f51fb209dea15f0b0 Gerrit-Change-Number: 17209 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 20 Mar 2021 00:01:24 +0000 Gerrit-HasComments: Yes
