Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17185 )
Change subject: IMPALA-10483: Support subqueries in Ranger masking policies ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Let me know if you are planning to make any other changes based on the column masking patch or add any new test. If not, I can upgrade to a +2. http://gerrit.cloudera.org:8080/#/c/17185/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17185/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-10483: Support subqueries in Ranger masking policies > I think COMPUTE STATS should be blocked since it required ALTER privilege ( Added a comment in IMPALA-10554 about COMPUTE STATS so we can track. http://gerrit.cloudera.org:8080/#/c/17185/2/testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test File testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test: http://gerrit.cloudera.org:8080/#/c/17185/2/testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test@167 PS2, Line 167: INT,BOOLEAN,STRING > The row filter can have any expressions as long as they are correct in synt Yeah, it should be ok since you are doing a a textual substitution and calling the parser. I am ok with not adding tests for expressions. -- To view, visit http://gerrit.cloudera.org:8080/17185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254df9f684c95c660f402abd99ca12dded7e764f Gerrit-Change-Number: 17185 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 21 Mar 2021 18:26:27 +0000 Gerrit-HasComments: Yes
