Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17210 )

Change subject: IMPALA-10598: Deflake test_cache_reload_validation
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17210/1/tests/query_test/test_hdfs_caching.py
File tests/query_test/test_hdfs_caching.py:

http://gerrit.cloudera.org:8080/#/c/17210/1/tests/query_test/test_hdfs_caching.py@349
PS1, Line 349: line for line in stdout.split('\n') if
             :       line.strip(' \n') != ''
> nit: I think this can be simplified as
Done


http://gerrit.cloudera.org:8080/#/c/17210/1/tests/query_test/test_hdfs_caching.py@363
PS1, Line 363:     else:
             :       count = len(stdout.split('\n'))
             :     return count
> nit: return len(stdout.split('\n'))
Done



--
To view, visit http://gerrit.cloudera.org:8080/17210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d491e90af461d5db3575a5840958d17ca90901c
Gerrit-Change-Number: 17210
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Wed, 24 Mar 2021 20:58:16 +0000
Gerrit-HasComments: Yes

Reply via email to